Adds APP_URL as base tag href to enable loading via ui via ingress ro…#2195
Merged
FxKu merged 1 commit intozalando:masterfrom Feb 15, 2023
Merged
Adds APP_URL as base tag href to enable loading via ui via ingress ro…#2195FxKu merged 1 commit intozalando:masterfrom
FxKu merged 1 commit intozalando:masterfrom
Conversation
simo9000
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi and
sdudoladov
as code owners
Member
|
👍 |
Member
|
👍 |
Member
|
Thanks @simo9000 ! Good to have this localhost address not hard-coded anymore in the deployment template. |
FxKu
reviewed
Aug 23, 2023
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <base href="{{app_url}}"> |
Member
There was a problem hiding this comment.
@simo9000 unfortunately, this change introduces a breaking change, see #2302. Now everybody has to set appUrl because with the default localhost appUrl as base the app will not load. App URL is only used for authorization. The rest is full links. Maybe most users haven't used it so having it hardcoded in deployment.yaml template was fine. I have to read up on ingress rules, but can you tell us why you need this to be changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
This change enables configuration to allow the ui to be accessed via ingress rules.